feat: Support API token for scanning hf://
#17682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17682 +/- ##
==========================================
+ Coverage 80.37% 80.40% +0.02%
==========================================
Files 1500 1500
Lines 196605 196640 +35
Branches 2793 2793
==========================================
+ Hits 158016 158103 +87
+ Misses 38076 38024 -52
Partials 513 513 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
stinodego,
orlp and
c-peters
as code owners
|
Thanks for the fast implementation. Just a nit comment: do you think the parameter could be named just "token"? It seems a bit redundant to call it "hf_token" when it is already passed to the "hf://" URL... |
nameexhaustion
changed the title
hf_token for scanning hf://hf://
|
Can we add an entry in the docstring for discoverability? (Aside from the user guide) |
nameexhaustion
requested review from
alexander-beedie,
MarcoGorelli and
reswqa
as code owners
nameexhaustion
commented
Jul 18, 2024
| @@ -59,12 +59,14 @@ def read_parquet( | |||
| Parameters | |||
| ---------- | |||
| source | |||
| Path to a file or a file-like object (by "file-like object" we refer to objects | |||
| Path(s) to a file or directory | |||
| When needing to authenticate for scanning cloud locations, see the `storage_options` | |||
There was a problem hiding this comment.
update docs for source to point to cloud options
nameexhaustion
commented
Jul 18, 2024
nameexhaustion
commented
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for scanning from private repositories with an API token:
or alternatively, using an environment variable
export HF_TOKEN=... python main.pyref #17625